Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick changes for WordPress 6.5 RC2 #59756

Merged
merged 20 commits into from
Mar 12, 2024
Merged

Cherry Pick changes for WordPress 6.5 RC2 #59756

merged 20 commits into from
Mar 12, 2024

Commits on Mar 11, 2024

  1. Interactivity API: Fix context object proxy references (#59553)

    * Add failing test
    
    * Fix returned proxy reference
    
    * Add more reference tests
    
    * Fix assignment of context objects
    
    * Update comment
    
    * Update changelog
    
    Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
    Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
    3 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    dcce36d View commit details
    Browse the repository at this point in the history
  2. Font Library: Load/Unload the font face in browser when toggling the …

    …variants (#59066)
    
    * Font Library: Load/Unload the font face in browser when toggling the variants
    
    * Font Library: Unload the deleted font faces
    
    * Address feedback
    
    * replace repeated implementation by the use of a existing fuction
    
    * remove inaccurate comment
    
    * added a formatFontFace call to be able to match fonts in firefox too.
    
    ---------
    
    Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com>
    
    ---
    Co-authored-by: arthur791004 <arthur791004@git.wordpress.org>
    Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
    Co-authored-by: okmttdhr <okat@git.wordpress.org>
    5 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    59e7d64 View commit details
    Browse the repository at this point in the history
  3. Navigation Block: Fix erroneous escaping of ampersands (etc) (#59561)

    Fix erroneous escaping of ampersands to `u0026amp;`. 
    
    This is done by using the [`rest_pre_insert_{$this->post_type}`](https://developer.wordpress.org/reference/hooks/rest_pre_insert_this-post_type/) _filter_ rather than the `rest_insert_wp_navigation` _action_. This avoids calling `wp_update_post` twice, which was the original reason of the issue, as it removed the backslash from the already-encoded entity.
    
    Unlinked contributors: kylekelly.
    
    Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
    Co-authored-by: t-hamano <wildworks@git.wordpress.org>
    Co-authored-by: tjcafferkey <tomjcafferkey@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: draganescu <andraganescu@git.wordpress.org>
    Co-authored-by: annezazu <annezazu@git.wordpress.org>
    Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
    Co-authored-by: getdave <get_dave@git.wordpress.org>
    Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
    10 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b455d76 View commit details
    Browse the repository at this point in the history
  4. Change fillRule property (#59598)

    SantosGuillamot authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3c42446 View commit details
    Browse the repository at this point in the history
  5. Site Editor: Fix Global Styles outdated output (#59628)

    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: jasmussen <joen@git.wordpress.org>
    Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
    4 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    984ede0 View commit details
    Browse the repository at this point in the history
  6. Add pattern title in create modal in post editor (#59550)

    Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
    Co-authored-by: jasmussen <joen@git.wordpress.org>
    Co-authored-by: carolinan <poena@git.wordpress.org>
    Co-authored-by: t-hamano <wildworks@git.wordpress.org>
    7 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4e8563f View commit details
    Browse the repository at this point in the history
  7. Fix typo in Dataviews Pagination and Font Collection components (#59656)

    Co-authored-by: rcoll <rdcoll@git.wordpress.org>
    2 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4958400 View commit details
    Browse the repository at this point in the history
  8. Font Library: Fix typo in upload text (#59655)

    A typo in font uploader string
    
    Co-authored-by: mujuonly <mujuonly@git.wordpress.org>
    2 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b3c9f8b View commit details
    Browse the repository at this point in the history
  9. List view: fix stuck moving animation on Enter (#59644)

    Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
    Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
    3 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c66577a View commit details
    Browse the repository at this point in the history
  10. Site Editor: Restore the back button when navigating to the template …

    …from the home page (#59639)
    
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
    Co-authored-by: getdave <get_dave@git.wordpress.org>
    4 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    67b216a View commit details
    Browse the repository at this point in the history
  11. Site editor: Fix opening of save panel when using the save shortcut (

    …#59647)
    
    Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
    Co-authored-by: jasmussen <joen@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org>
    Co-authored-by: annezazu <annezazu@git.wordpress.org>
    Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
    Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
    8 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    00fcb56 View commit details
    Browse the repository at this point in the history
  12. Code block: preserve newlines (#59627)

    Unlinked contributors: oldrup.
    
    Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
    Co-authored-by: t-hamano <wildworks@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: timnolte <tnolte@git.wordpress.org>
    Co-authored-by: justintadlock <greenshady@git.wordpress.org>
    Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
    7 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b78d306 View commit details
    Browse the repository at this point in the history
  13. Implement pattern overrides behind IS_GUTENBERG_PLUGIN flag (#59702)

    Co-authored-by: talldan <talldanwp@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: getdave <get_dave@git.wordpress.org>
    4 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    dee8699 View commit details
    Browse the repository at this point in the history
  14. Ensure that errors reported from uploading font files are not duplica…

    …ted (#59564)
    
    Co-authored-by: pbking <pbking@git.wordpress.org>
    Co-authored-by: getdave <get_dave@git.wordpress.org>
    Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
    Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: mikachan <mikachan@git.wordpress.org>
    7 people authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    77aff9d View commit details
    Browse the repository at this point in the history
  15. Dataviews: Fix sticky table headers (#59467)

    Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
    Co-authored-by: t-hamano <wildworks@git.wordpress.org>
    Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
    Co-authored-by: annezazu <annezazu@git.wordpress.org>
    # Conflicts:
    #	packages/dataviews/src/style.scss
    jameskoster authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e67cb2f View commit details
    Browse the repository at this point in the history
  16. Interactivity: Restore scope on thrown exception in async callback (#…

    …59708)
    
    Ensure scope is properly restored when an exception is thrown in a generator callback.
    
    For example, the following block should have the correct context in the catch block:
    
    try {
      yield Promise.reject( '💥' );
    } catch ( err ) {
      getContext().error = err;
    }
    
    ---
    
    Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
    Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
    Co-authored-by: gziolo <gziolo@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>
    # Conflicts:
    #	packages/interactivity/CHANGELOG.md
    sirreal authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    588cc8b View commit details
    Browse the repository at this point in the history
  17. Font Library: Refactors the upload handler in order to check if files…

    … being uploaded are valid font files. (#59648)
    
    * Font Library: check if file upload is valid font
    
    Fixes: #59578
    
    Refactors the upload handler in order to check if files being uploaded
    are valid font files.
    
    * make sure error message is relevant
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    
    * error message syntax
    
    * use WordPress yoda condition
    
    * Respect string freeze
    
    * Fix lint
    
    ---------
    
    Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
    Co-authored-by: Dave Smith <getdavemail@gmail.com>
    3 people committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7719a93 View commit details
    Browse the repository at this point in the history
  18. Fix allow mouse users to edit link text when Link UI is active (#59635)

    * PoC
    
    * Fix cmd + K with click
    
    * Adding mutually exclusive states
    
    * Sync internal state with format active state
    
    * Fix broken anchors for Links
    
    * Improve variable naming
    
    * Normalize more variable names
    
    * Fix sub formats breaking click to edit
    
    * Force constrainedTabbing for link ui
    
    * Handle nested formats
    
    * Revert change to hasLink var
    
    * Locate const at top of file
    
    * Improve comment
    
    * Add test for editing text
    
    * Improve var naming
    
    * Correct comments
    
    * Make new prop unstable
    
    * Revert useAnchor API
    
    ---------
    
    Co-authored-by: getdave <get_dave@git.wordpress.org>
    Co-authored-by: jeryj <jeryj@git.wordpress.org>
    Co-authored-by: draganescu <andraganescu@git.wordpress.org>
    Co-authored-by: scruffian <scruffian@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    Co-authored-by: bacoords <bacoords@git.wordpress.org>
    Co-authored-by: joedolson <joedolson@git.wordpress.org>
    Co-authored-by: annezazu <annezazu@git.wordpress.org>
    Co-authored-by: richtabor <richtabor@git.wordpress.org>
    Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
    11 people committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7080b67 View commit details
    Browse the repository at this point in the history
  19. Fix create menu after menu switch (#59630)

    * don't set creating menu flag on menu switch
    
    * return Promises from the navigation menu ref changing functions to be able to clean state after ref is updated
    
    * update tests
    
    * await the menu creation
    
    * stub test updates
    
    * revert test changes and remove decorative promises
    
    * do not disable the UI when changing the navigation, disable the UI based on resolving menus
    
    * block the UI for menu switching too, update tests with some comments, undo the focus update
    
    * properly disable menu choices via their choices prop
    
    Co-authored-by: draganescu <andraganescu@git.wordpress.org>
    Co-authored-by: scruffian <scruffian@git.wordpress.org>
    Co-authored-by: jeryj <jeryj@git.wordpress.org>
    Co-authored-by: getdave <get_dave@git.wordpress.org>
    Co-authored-by: afercia <afercia@git.wordpress.org>
    # Conflicts:
    #	packages/block-library/src/navigation/edit/test/navigation-menu-selector.js
    draganescu authored and getdave committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b2128cd View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Site Editor: Fix selected featured image when opening media library (#…

    …59769)
    
    Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
    Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
    3 people authored and getdave committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e5f7dd6 View commit details
    Browse the repository at this point in the history