Add polish #6138
Add polish #6138
Conversation
Love this. |
| @@ -129,7 +129,7 @@ export const settings = { | |||
| value={ id } | |||
| render={ ( { open } ) => ( | |||
| <Button isLarge onClick={ open }> | |||
| { __( 'Add from Media Library' ) } | |||
| { __( 'Media Library' ) } | |||
There was a problem hiding this comment.
Are these duplicated buttons needed if that's the default for the component?
There was a problem hiding this comment.
Not sure — I just changed the labels already there.
|
Pushed a fix to tweak the breadcrumb arrow to use the same as the image url button. I can see that I'll need to rebase in a second.
|
This uses variables for colors and shadows, and also fixes a regression with the link dialog when linking an image. However there's still a bug here, where as soon as you start typing in the image link dialog, the entire thing disappears and you can't type. This is possibly due to isEditing mode being invoked there. Can you take a look, @noisysocks @karmatosed?
This adds a white background, and some things, to the Pagination block. This will only be visible if a user loads a stylesheet into the editor. Fixes #1467 (comment), cc @swissspidy.
This makes the placeholders fit better in small breakpoints.
This makes the left arrow consistent with the one used when creating links on images.
jasmussen
force-pushed
the
polish/more-polish
branch
from
59f3d76
to
6425897
Compare
|
Looks good to me. 🚢 |
|
Woop woop! |
It looks like this regression was introduced in #5513. I'll create an issue. |
|
This PR contains 3 sets of fixes.
The first polishes the link dialog a bit, by using color variables. Notably it fixes a regression with the Image link:
There's still an issue here, though, as soon as you start typing in the link dialog for images, it disappears. I suspect isEditing is kicking in and hiding the block toolbars. CC: @noisysocks
The second part unifies the styles between readmore and pagination:
The third is a fix to make sure that placeholders fit in tight spots, by including a shorter Media Library label. It also makes the font sizes on those buttons consistent with all other Gutenberg buttons: