New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polish #6138

Merged
merged 4 commits into from Apr 12, 2018

Conversation

Projects
None yet
4 participants
@jasmussen
Contributor

jasmussen commented Apr 12, 2018

This PR contains 3 sets of fixes.

The first polishes the link dialog a bit, by using color variables. Notably it fixes a regression with the Image link:

screen shot 2018-04-12 at 11 01 05

There's still an issue here, though, as soon as you start typing in the link dialog for images, it disappears. I suspect isEditing is kicking in and hiding the block toolbars. CC: @noisysocks

The second part unifies the styles between readmore and pagination:

screen shot 2018-04-12 at 11 38 52

The third is a fix to make sure that placeholders fit in tight spots, by including a shorter Media Library label. It also makes the font sizes on those buttons consistent with all other Gutenberg buttons:

screen shot 2018-04-12 at 12 03 17

@jasmussen jasmussen self-assigned this Apr 12, 2018

@jasmussen jasmussen requested review from karmatosed, swissspidy and WordPress/gutenberg-core Apr 12, 2018

@mtias

This comment has been minimized.

Contributor

mtias commented Apr 12, 2018

The third is a fix to make sure that placeholders fit in tight spots, by including a shorter Media Library label.

Love this.

@@ -129,7 +129,7 @@ export const settings = {
value={ id }
render={ ( { open } ) => (
<Button isLarge onClick={ open }>
{ __( 'Add from Media Library' ) }
{ __( 'Media Library' ) }

This comment has been minimized.

@mtias

mtias Apr 12, 2018

Contributor

Are these duplicated buttons needed if that's the default for the component?

This comment has been minimized.

@jasmussen

jasmussen Apr 12, 2018

Contributor

Not sure — I just changed the labels already there.

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 12, 2018

Pushed a fix to tweak the breadcrumb arrow to use the same as the image url button. I can see that I'll need to rebase in a second.

screen shot 2018-04-12 at 12 20 41

jasmussen added some commits Apr 12, 2018

Polish link dialog.
This uses variables for colors and shadows, and also fixes a regression with the link dialog when linking an image.

However there's still a bug here, where as soon as you start typing in the image link dialog, the entire thing disappears and you can't type. This is possibly due to isEditing mode being invoked there. Can you take a look, @noisysocks @karmatosed?
Unify markup between More block and Pagination block
This adds a white background, and some things, to the Pagination block. This will only be visible if a user loads a stylesheet into the editor.

Fixes #1467 (comment), cc @swissspidy.
Unify button sizes, and slim down "Media Library".
This makes the placeholders fit better in small breakpoints.
Change left arrow on breadcrumbs.
This makes the left arrow consistent with the one used when creating links on images.
@mtias

This comment has been minimized.

Contributor

mtias commented Apr 12, 2018

Looks good to me. 🚢

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 12, 2018

Woop woop!

@jasmussen jasmussen merged commit a481c2c into master Apr 12, 2018

2 checks passed

codecov/project 44.44% remains the same compared to 611c0f5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the polish/more-polish branch Apr 12, 2018

@noisysocks

This comment has been minimized.

Member

noisysocks commented Apr 13, 2018

I suspect isEditing is kicking in and hiding the block toolbars. CC: @noisysocks

It looks like this regression was introduced in #5513. I'll create an issue.

@jasmussen jasmussen added this to the 2.7 milestone Apr 13, 2018

@aduth

This comment has been minimized.

Member

aduth commented Apr 18, 2018

I suspect isEditing is kicking in and hiding the block toolbars. CC: @noisysocks

It looks like this regression was introduced in #5513. I'll create an issue.

Related: #5942, #5894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment