Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused block-transformations component #7594

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Remove unused block-transformations component #7594

merged 1 commit into from
Jul 2, 2018

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jun 28, 2018

Description

Deletes the react component 'BlockTransformations'.

This was previously shown in the block settings menu. Usage of this component was removed in commit 3e76aad, but the component itself was left behind. As it's now completely unused this commit removes it.

How has this been tested?

  • Searched for imports of file. There is none.
  • Ensured unit tests pass.
  • Did a manual test of the block settings menu
  • Did a manual test of block transformations using the block toolbar

Types of changes

  • Dead code removal

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@talldan
Remove unused block-transformations component
acb1c8d 
Usage of this component was removed in commit 3e76aad, but the
component itself was left behind. As it's now completely unused
this commit removes it.
@talldan talldan added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 28, 2018
@talldan talldan self-assigned this Jun 28, 2018
@talldan talldan requested a review from noisysocks June 28, 2018 07:28
noisysocks
noisysocks approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@noisysocks noisysocks added this to the 3.2 milestone Jul 2, 2018
@talldan talldan merged commit a69100a into master Jul 2, 2018
@talldan talldan deleted the remove/block-transformations-component branch July 2, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

Assignees

@talldan talldan

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@talldan @noisysocks