Shared blocks: Fix: Name field isn't focused when a shared block is created #7987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
approved these changes
Jul 17, 2018
| @@ -23,6 +23,13 @@ class SharedBlockEditPanel extends Component { | |||
| this.handleTitleKeyDown = this.handleTitleKeyDown.bind( this ); | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
| // Select the input text when the form opens. | |||
| if( this.props.isEditing && this.titleField.current ){ | |||
There was a problem hiding this comment.
Missing some spaces around the ()s here.
jorgefilipecosta
force-pushed
the
fix/focus-Name-when-a-shared-block-is-created
branch
from
1c16f02
to
be50d7a
Compare
jorgefilipecosta
deleted the
fix/focus-Name-when-a-shared-block-is-created
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure when we use the option to convert to a shared block name field is automatically selected.
Before we had logic using componentDidUpdate but this logic was not used when the component is mounted so now we apply similar logic on the mount.
Fixes: #7972
How has this been tested?
Create a block
Click More Options and select Convert to Shared Block
Verify the name field is selected.