Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wide toolbar regression. #9083

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Fix wide toolbar regression. #9083

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4f2a59
Fix wide toolbar regression.
jasmussen Aug 17, 2018
c29328d
Scope the fix beyond mobile.
jasmussen Aug 17, 2018
a869a62
Use the right breakpoint.
jasmussen Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/editor/src/components/block-toolbar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.editor-block-toolbar {
display: flex;
// Should be inline-flex so it isn't full-wide.
// We leverage this to center the toolbar on wide and full-wide images.
display: inline-flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be flex though to fix the toolbar in mobile in several browsers. I think we should leave it flex here and try to override the editor-context-toolbar instead for wide alignments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could work too. So to understand you correctly, this was not done as part of IE11 fixes?

I'll push fixes for wide and fullwide in a minute.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was but I think it affected several browsers, I'm testing right now to confirm

flex-grow: 1;
width: 100%;
overflow: auto; // Allow horizontal scrolling on mobile.
Expand Down