Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove references to the upstream database in the API #1057

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

AetherUnbound
Copy link
Contributor

Fixes

This is a follow up to this comment on the API ECS migration effort: https://github.com/WordPress/openverse-infrastructure/pull/323#discussion_r1055052813

For those without access, @sarayourfriend pointed out that the UPSTREAM_* variables could be removed from the API, since there are ostensibly no references to it in the API code.

Description

This PR removes the upstream database configuration and the related UPSTREAM_* variables from the API. I've run both the unit tests and the integration tests locally, and also navigated through the API a bit. Everything looks fine!

Testing Instructions

Build and play around with the API to make sure everything still works.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner December 23, 2022 19:18
@AetherUnbound AetherUnbound added 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Dec 23, 2022
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that we had this unused config lying around. LGTM!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. LGTM

@AetherUnbound AetherUnbound force-pushed the feature/remove-upstream-variables branch from b30493b to 9e413db Compare January 2, 2023 23:12
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/1057

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@AetherUnbound AetherUnbound merged commit b0eab25 into main Jan 2, 2023
@AetherUnbound AetherUnbound deleted the feature/remove-upstream-variables branch January 2, 2023 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants