This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Remove references to the upstream database in the API #1057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This is a follow up to this comment on the API ECS migration effort: https://github.com/WordPress/openverse-infrastructure/pull/323#discussion_r1055052813
For those without access, @sarayourfriend pointed out that the
UPSTREAM_*
variables could be removed from the API, since there are ostensibly no references to it in the API code.Description
This PR removes the
upstream
database configuration and the relatedUPSTREAM_*
variables from the API. I've run both the unit tests and the integration tests locally, and also navigated through the API a bit. Everything looks fine!Testing Instructions
Build and play around with the API to make sure everything still works.
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin