This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
Url Module: Drop the browser built file and the useless dependencies #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested using the url module in Gutenberg using
npm ln
.The good news is:
The bad news is:
I also removed the
url
dependencies in this PR because these are included in Node.js by defaultcore
and webpack automatically include them if they're used in a webpack built application.I'm hoping we could release the first version of this module after the merge. I hesitated to update the package version to 1.0.0 (any thoughts on this?).