This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
a11y: Use screen-reader-text styles for speak container #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
This pull request seeks to resolve the a11y speak container styling issues noted at #38. Specifically, the updated styles help avoid a scroll overflow issue, doing so by copying the
.screen-reader-text
styles used elsewhere in the WordPress codebase:https://github.com/WordPress/WordPress/blob/4.8.2/wp-admin/css/common.css#L120-L133
Open questions:
After publishing this branch, I noted that the styles have since been updated in the trunk branch to use modern CSS properties. We may consider adopting those styles here (cc @afercia).
WordPress/WordPress@c65fe27
Testing instructions:
The original issue was observed in overflow apparent in Gutenberg prior to the workaround put in place in WordPress/gutenberg@0f77b9c . Verify that prior to this commit, with these changes, no overflow exists:
a11y
package:cd packages/a11y && npm ln
git checkout 04727b731a2ec307c9bad1d9d239d3c5e01f89a4
@wordpress/a11y
branch:npm ln @wordpress/a11y
npm run dev