Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate U2F keys to WebAuthn #491

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

mcguffin
Copy link

@mcguffin mcguffin commented Nov 6, 2022

This is a proof of concept and a follow-up for #427.

The transformation is happening in includes/WebAuthn/class-webauthn-key-migrator.php. The PHP is mainly gathered together from sjinks/wp-two-factor-provider-webauthn and madwizard-org/webauthn-server.

Apart from reviewing, here's what I think should be the next steps:

  • Key migration is currently triggered by the user in the U2F keys admin table. However we could do it automatically, eg. when the user is visiting his/her profile page, like sjinks/wp-two-factor-provider-webauthn does. I'm feeling indecisive about it and I'm looking forward for your feedback and opinions.
  • Add an admin message after a key has been migrated.
  • Real life testing with actual U2F / YubiKeys
  • Unit tests

@burnedfaceless
Copy link

@dd32 Can you please merge this pull request for me? I would really like to be able to use my U2F Keys again.

@dd32
Copy link
Member

dd32 commented Feb 6, 2023

dd32 Can you please merge this pull request for me?

This isn't my call. I would suggest using a plugin that adds a WebAuthN provider in the meantime: https://wordpress.org/plugins/two-factor-provider-webauthn/
(edit: Worth mentioning; I haven't reviewed that plugin, I know others who use it, I don't know if the future built-in Two Factor WebAuthN support will support it or migrate those registered keys)

@jeffpaul jeffpaul modified the milestones: 0.9.0, 0.10.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants