Limit decoding attribute to images with src starting with double quote

[adamsilverstein]

Trac ticket: https://core.trac.wordpress.org/ticket/56969

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[felixarntz]

@adamsilverstein Looks solid to me, just two nit-picks here in the test HTML.

[peterwilsoncc]

This seems Ok as temporary fix but as single quotes are a perfectly legitimate form of HTML, it would be good to follow up with something more elegant.

WordPress itself uses the quote types interchangeably and it seems to be fairly common in plugins too, especially when generating the markup from a set of variables.

wordpress-develop/src/wp-includes/pluggable.php

Line 2890 in 55d2653

"<img alt='%s' src='%s' srcset='%s' class='%s' height='%d' width='%d' %s/>",

[mukeshpanchal27]

Thanks @adamsilverstein. It looks good to me left some feedback for space and text changes.

https://github.com/WordPress/wordpress-develop/blob/trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php contains all the unit tests for wp_img_tag_add_decoding_attr() so is it better to move this new unit test there?

[desrosj]

Applied some of the more straightforward suggestions. @adamsilverstein would you be able to get this committed at some point today?

[adamsilverstein]

Yes, will do.

[adamsilverstein]

This seems Ok as temporary fix but as single quotes are a perfectly legitimate form of HTML, it would be good to follow up with something more elegant.

WordPress itself uses the quote types interchangeably and it seems to be fairly common in plugins too, especially when generating the markup from a set of variables.

wordpress-develop/src/wp-includes/pluggable.php

Line 2890 in 55d2653

"<img alt='%s' src='%s' srcset='%s' class='%s' height='%d' width='%d' %s/>",

I agree it would be nice to have a more robust solution; this one seems ok for now - especially since the lazy attribute callback already has an identical check.

[adamsilverstein]

Applied some of the more straightforward suggestions. @adamsilverstein would you be able to get this committed at some point today?

@desrosj I'll get this committed and backported first thing tomorrow if you don't beat me to it.

[peterwilsoncc]

Merged in https://core.trac.wordpress.org/changeset/54802 / 5103242

[adamsilverstein]

thanks @peterwilsoncc!