Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Hooks: Process blocks more efficiently. #5753

Draft
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Dec 10, 2023

Previously the block hooks system has been parsing the entire post's content into blocks, processing those blocks, and then re-serializing the blocks back into HTML.

In this patch we're exploring a method of using the tokenizer from the block parser in order to scan through a post and find the block delimiters while avoiding performing a full recursive parse of blocks we don't care about.

cc: @ockham

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Previously the block hooks system has been parsing the entire post's content
into blocks, processing those blocks, and then re-serializing the blocks
back into HTML.

In this patch we're exploring a method of using the tokenizer from the block
parser in order to scan through a post and find the block delimiters while
avoiding performing a full recursive parse of blocks we don't care about.

Co-authored-by: Bernie Reiter <bernhard-reiter@git.wordpress.org>
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants