Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twenty-Three: Replace the screenshot #6451

Closed

Conversation

carolinan
Copy link
Contributor

Replace the screenshot in Twenty Twenty-Three to remove the visible style variation sidebar.

This image is 9.44Kib larger than the old, but I think there is an action to compress the image when committing?

Trac ticket: https://core.trac.wordpress.org/ticket/56949


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@carolinan carolinan marked this pull request as ready for review April 26, 2024 08:50
Copy link

github-actions bot commented Apr 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props poena, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sabernhardt
Copy link

r57322 added themes' images to a Grunt task, so this should be compressed automatically. If you would like to minify manually, TinyPNG can reduce the size to less than 38KB, and I did not notice a significant visual difference.

For the image content, I like that it shows the theme's Call to Action pattern (WordPress.com's screenshot does not). Typography and color choices can vary greatly between style variations, but the pattern is common to all variations and special to the theme.

@carolinan
Copy link
Contributor Author

The screenshot is from the same demo, 2023.wordpress.net. I hid the featured images because I didn't know their license.

@SergeyBiryukov
Copy link
Member

Thanks for the PR! This was merged in r58179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants