-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling for __default attribute to block bindings for pattern overrides #6694
Add handling for __default attribute to block bindings for pattern overrides #6694
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3faccb6
to
45b91d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really speak to the code as I'm not familiar with block bindings logic but this is working well for me in testing, both when creating a pattern from existing post content and creating one from scratch in the site editor.
src/wp-includes/class-wp-block.php
Outdated
$updated_bindings = array(); | ||
|
||
/* | ||
* Build an binding array of all supported attributes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "build a binding array"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed in cbc99b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in my testing!
Committed in r58289. |
Trac ticket: https://core.trac.wordpress.org/ticket/61333
This is the PHP backport for the gutenberg PR WordPress/gutenberg#60694.
It adds handling for a
__default
block binding attribute for pattern overrides. When this binding attribute is encountered by the block binding code it dynamically adds support for all supported block binding attributes.Testing instructions
This has been rebased with the latest package updates, so is now fully testable.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.