chore: Merge prerelease/minor into prerelease/major (#2174)

Workday · Apr 27, 2023 · e3e9468 · e3e9468
2 parents 87c72e1 + 1903655
commit e3e9468
Show file tree

Hide file tree

Showing 41 changed files with 212 additions and 116 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,36 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [v8.6.1](https://github.com/Workday/canvas-kit/releases/tag/v8.6.1) (2023-04-26)
+
+### Components
+
+- fix(menu): Menu does not close with aria-disabled=true ([#2128](https://github.com/Workday/canvas-kit/pull/2128)) ([@NicholasBoll](https://github.com/NicholasBoll), manuel.carrera)
+- fix(form-field): Forward required prop to input ([#2154](https://github.com/Workday/canvas-kit/pull/2154)) ([@NicholasBoll](https://github.com/NicholasBoll))
+
+### Dependencies
+
+- fix: Add react-dom peer-dep to main package ([#2162](https://github.com/Workday/canvas-kit/pull/2162)) ([@alanbsmith](https://github.com/alanbsmith))
+
+### Infrastructure
+
+- fix: Update release action to support node 16 ([#2170](https://github.com/Workday/canvas-kit/pull/2170)) ([@RayRedGoose](https://github.com/RayRedGoose))
+
+
+## [v7.4.11](https://github.com/Workday/canvas-kit/releases/tag/v7.4.11) (2023-04-26)
+
+### Components
+
+- fix(menu): Menu does not close with aria-disabled=true ([#2128](https://github.com/Workday/canvas-kit/pull/2128)) ([@NicholasBoll](https://github.com/NicholasBoll), manuel.carrera)
+- fix(form-field): Forward required prop to input ([#2154](https://github.com/Workday/canvas-kit/pull/2154)) ([@NicholasBoll](https://github.com/NicholasBoll))
+
+### Dependencies
+
+- fix: Add react-dom peer-dep to main package ([#2162](https://github.com/Workday/canvas-kit/pull/2162)) ([@alanbsmith](https://github.com/alanbsmith))
+
+### Infrastructure
+
+- fix: Update release action to support node 16 ([#2170](https://github.com/Workday/canvas-kit/pull/2170)) ([@RayRedGoose](https://github.com/RayRedGoose))
 ## [v8.6.0](https://github.com/Workday/canvas-kit/releases/tag/v8.6.0) (2023-04-20)
 
 ### Components

diff --git a/cypress/integration/FormField.spec.ts b/cypress/integration/FormField.spec.ts
@@ -54,8 +54,8 @@ describe('Form Field', () => {
       cy.checkA11y();
     });
 
-    it('the asterisk should a title attribute set to "required"', () => {
-      cy.get('abbr').should('have.attr', 'title', 'required');
+    it('the input should have a "required" attribute', () => {
+      cy.findByRole('textbox', {name: 'Email'}).should('have.attr', 'required');
     });
   });
 });
diff --git a/cypress/integration/Menu.spec.ts b/cypress/integration/Menu.spec.ts
@@ -43,6 +43,14 @@ describe('Menu', () => {
         cy.findByRole('menuitem', {name: 'First Item'}).should('have.focus');
       });
 
+      it('should have aria-disabled=true', () => {
+        cy.findByRole('menuitem', {name: 'Fourth Item'}).should(
+          'have.attr',
+          'aria-disabled',
+          'true'
+        );
+      });
+
       context('when escape key is pressed', () => {
         beforeEach(() => {
           cy.focused().type('{esc}');
@@ -119,6 +127,24 @@ describe('Menu', () => {
         });
       });
 
+      context('when the fourth item is clicked', () => {
+        beforeEach(() => {
+          cy.contains('button', 'Fourth Item').click();
+        });
+
+        it('should not close the menu', () => {
+          cy.findByRole('menu').should('be.visible');
+        });
+
+        it('should have aria-expanded set to true', () => {
+          cy.findByRole('button', {name: 'Open Menu'}).should('have.attr', 'aria-expanded', 'true');
+        });
+
+        it('should not select the fourth item', () => {
+          cy.findByTestId('output').should('not.contain', '4');
+        });
+      });
+
       context('when the tab key is pressed', () => {
         beforeEach(() => {
           cy.focused().tab();
@@ -155,6 +181,28 @@ describe('Menu', () => {
         it('should focus on the last option', () => {
           cy.findByRole('menuitem', {name: 'Fourth Item'}).should('have.focus');
         });
+
+        context('when the enter key is pressed', () => {
+          beforeEach(() => {
+            cy.focused().type('{enter}');
+          });
+
+          it('should not close the menu', () => {
+            cy.findByRole('menu').should('be.visible');
+          });
+
+          it('should have aria-expanded set to true', () => {
+            cy.findByRole('button', {name: 'Open Menu'}).should(
+              'have.attr',
+              'aria-expanded',
+              'true'
+            );
+          });
+
+          it('should not select the fourth item', () => {
+            cy.findByTestId('output').should('not.contain', '4');
+          });
+        });
       });
     });
   });

diff --git a/lerna.json b/lerna.json
@@ -2,7 +2,7 @@
   "packages": [
     "modules/**"
   ],
-  "version": "8.6.0",
+  "version": "8.6.1",
   "npmClient": "yarn",
   "useWorkspaces": true,
   "command": {

diff --git a/modules/codemod/package.json b/modules/codemod/package.json
@@ -2,7 +2,7 @@
   "name": "@workday/canvas-kit-codemod",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "A collection of codemods for use on Workday Canvas Kit packages.",
   "main": "dist/es6/index.js",
   "sideEffects": false,

diff --git a/modules/css-fonts/package.json b/modules/css-fonts/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-fonts",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Fonts for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",

diff --git a/modules/css/action-bar/package.json b/modules/css/action-bar/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-action-bar",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Action bar CSS for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,8 +16,8 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/action-bar/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-button": "^8.6.0",
-    "@workday/canvas-kit-css-core": "^8.6.0"
+    "@workday/canvas-kit-css-button": "^8.6.1",
+    "@workday/canvas-kit-css-core": "^8.6.1"
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",

diff --git a/modules/css/badge/package.json b/modules/css/badge/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-badge",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "provides a summary indicator with dynamic values",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",

diff --git a/modules/css/banner/package.json b/modules/css/banner/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-banner",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Errors and alerts for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,7 +16,7 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/banner/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0",
+    "@workday/canvas-kit-css-core": "^8.6.1",
     "@workday/canvas-system-icons-web": "^3.0.0"
   },
   "scripts": {

diff --git a/modules/css/button/package.json b/modules/css/button/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-button",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "The button css for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,7 +16,7 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/button/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0",
+    "@workday/canvas-kit-css-core": "^8.6.1",
     "@workday/canvas-system-icons-web": "^3.0.0"
   },
   "scripts": {

diff --git a/modules/css/card/package.json b/modules/css/card/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-card",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Card CSS for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,7 +16,7 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/card/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0"
+    "@workday/canvas-kit-css-core": "^8.6.1"
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",

diff --git a/modules/css/checkbox/package.json b/modules/css/checkbox/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-checkbox",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "The checkbox css for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -29,7 +29,7 @@
     "workday"
   ],
   "dependencies": {
-    "@workday/canvas-kit-css-common": "^8.6.0",
-    "@workday/canvas-kit-css-core": "^8.6.0"
+    "@workday/canvas-kit-css-common": "^8.6.1",
+    "@workday/canvas-kit-css-core": "^8.6.1"
   }
 }
diff --git a/modules/css/common/package.json b/modules/css/common/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-common",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "The common css for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -28,6 +28,6 @@
     "workday"
   ],
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0"
+    "@workday/canvas-kit-css-core": "^8.6.1"
   }
 }
diff --git a/modules/css/core/package.json b/modules/css/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-core",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "The core css for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",

diff --git a/modules/css/form-field/package.json b/modules/css/form-field/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-form-field",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "The form css for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,16 +16,16 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/form-field/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-common": "^8.6.0",
-    "@workday/canvas-kit-css-core": "^8.6.0",
+    "@workday/canvas-kit-css-common": "^8.6.1",
+    "@workday/canvas-kit-css-core": "^8.6.1",
     "@workday/canvas-system-icons-web": "^3.0.0"
   },
   "devDependencies": {
-    "@workday/canvas-kit-css-checkbox": "^8.6.0",
-    "@workday/canvas-kit-css-radio": "^8.6.0",
-    "@workday/canvas-kit-css-select": "^8.6.0",
-    "@workday/canvas-kit-css-text-area": "^8.6.0",
-    "@workday/canvas-kit-css-text-input": "^8.6.0"
+    "@workday/canvas-kit-css-checkbox": "^8.6.1",
+    "@workday/canvas-kit-css-radio": "^8.6.1",
+    "@workday/canvas-kit-css-select": "^8.6.1",
+    "@workday/canvas-kit-css-text-area": "^8.6.1",
+    "@workday/canvas-kit-css-text-input": "^8.6.1"
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",

diff --git a/modules/css/icon/package.json b/modules/css/icon/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-icon",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Icon toolkit for Canvas kit",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -17,7 +17,7 @@
   },
   "dependencies": {
     "@workday/canvas-colors-web": "^2.0.0",
-    "@workday/canvas-kit-css-core": "^8.6.0",
+    "@workday/canvas-kit-css-core": "^8.6.1",
     "svg-injector": "^1.1.3",
     "to-slug-case": "^1.0.0"
   },

diff --git a/modules/css/layout/package.json b/modules/css/layout/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-layout",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Layout css for canvas-kit-css",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,7 +16,7 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/layout/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0"
+    "@workday/canvas-kit-css-core": "^8.6.1"
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",

diff --git a/modules/css/loading-dots/package.json b/modules/css/loading-dots/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-loading-dots",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Animations used while a page or component is loading.",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -17,7 +17,7 @@
     "directory": "modules/css/loading-dots"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0"
+    "@workday/canvas-kit-css-core": "^8.6.1"
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",

diff --git a/modules/css/menu/package.json b/modules/css/menu/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-menu",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Menu CSS for Canvas kit CSS",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,7 +16,7 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/menu/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0"
+    "@workday/canvas-kit-css-core": "^8.6.1"
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",

diff --git a/modules/css/modal/package.json b/modules/css/modal/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@workday/canvas-kit-css-modal",
-  "version": "8.6.0",
+  "version": "8.6.1",
   "description": "Modal CSS for Canvas kit CSS",
   "author": "Workday, Inc. (https://www.workday.com)",
   "license": "Apache-2.0",
@@ -16,8 +16,8 @@
     "url": "http://github.com/Workday/canvas-kit/tree/master/modules/modal/css"
   },
   "dependencies": {
-    "@workday/canvas-kit-css-core": "^8.6.0",
-    "@workday/canvas-kit-css-popup": "^8.6.0"
+    "@workday/canvas-kit-css-core": "^8.6.1",
+    "@workday/canvas-kit-css-popup": "^8.6.1"
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",