Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge master into prerelease/minor #2272

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

alanbsmith
Copy link
Member

This pull request was automatically created by an automated forward-merge job. The automated job failed automated checks and must be resolved manually.
Reasons for failure may include:

  • Merge conflicts that cannot be automatically resolved
  • A merge resulted in check failures
    • Lint or type errors
    • Test failures
    • Unexpected visual changes
      The pull request should inform you of merge conflicts before you start if any.
  1. Run the following commands in your terminal. If this succeeds, skip step 2. The last command will run a script that tries to merge and resolve conflicts automatically.
    git branch -D merge/master-into-prerelease/minor || true
    git fetch upstream
    git checkout merge/master-into-prerelease/minor
    git pull upstream merge/master-into-prerelease/minor -f
    node utils/forward-merge.js
    
  2. If the previous step succeeded, skip to step 3. Resolve conflicts manually. Then run the following.
    git add .
    git commit -m "chore: Merge master into prerelease/minor"
    
  3. Push the merge commit back to the pull request
    git push upstream merge/master-into-prerelease/minor
    

If there were no merge conflicts, the forward-merge job failed because of a test failure. You can wait for the pull request to give errors, or you can check the logs for failures. You'll have to update code to fix errors.
This pull request will be merged using the merge strategy instead of the squash strategy. This means any commit in the log will show in the branch's history. Any commit you make should amend the merge commit. Use the following command:

git commit --amend --no-edit

You must then force-push the branch and the CI will rerun verification.
Use the automerge label like normal and the CI will pick the correct merge strategy.

JeffreyRuder and others added 2 commits June 26, 2023 09:32
…2271)

Fixes: #2262  

This updates certain comments about the `options` prop of `Select` to better match the actual typing of the prop. The prop can include a mix of strings and objects, rather than just one or the other, but the comments did not make that clear.

[category:Documentation]
@cypress
Copy link

cypress bot commented Jun 26, 2023

1 flaky tests on run #5887 ↗︎

0 899 2 0 Flakiness 1

Details:

Merge be8a43b into 67ad53e...
Project: canvas-kit Commit: 608f1f269c ℹ️
Status: Passed Duration: 07:56 💡
Started: Jun 26, 2023 6:09 PM Ended: Jun 26, 2023 6:17 PM
Flakiness  cypress/integration/Autocomplete.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when a value is entered > when down arrow key is pressed > when the user presses the enter key > when the use hits the "2" key > should change the filtered results Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jamesfan jamesfan self-requested a review June 26, 2023 17:36
@alanbsmith alanbsmith merged commit 3170b49 into prerelease/minor Jun 26, 2023
@alanbsmith alanbsmith deleted the merge/master-into-prerelease/minor branch June 26, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants