Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): Spread props to input #2747

Merged
merged 2 commits into from
May 17, 2024

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented May 16, 2024

Summary

Fixes: #2744

Release Category

Components

Release Note

StyledRadio was spreading props to the input and it's parent div. This change removed spreading prop to the parent div except for className.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Copy link

cypress bot commented May 16, 2024

Passing run #7311 ↗︎

0 881 3 0 Flakiness 0

Details:

Merge 65c635a into a24167f...
Project: canvas-kit Commit: c6ed42d40b ℹ️
Status: Passed Duration: 04:55 💡
Started: May 17, 2024 2:47 PM Ended: May 17, 2024 2:51 PM

Review all test suite changes for PR #2747 ↗︎

@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label May 17, 2024
@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels May 17, 2024
@alanbsmith alanbsmith merged commit 505c9fb into Workday:support May 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants