chore: Update Avatar to use createStencil and createComponent #2783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starting to refactor the Avatar component to use the new
createStencil
andcreateComponent
conventions.Currently a WIP as these changes break the build - getting the following error:
ERROR in ./modules/react/avatar/lib/Avatar.tsx. Module build failed (from ./.storybook/style-transform-loader.js): Error: Unknown type at: "Property.AlignContent". Received "AlignContent"
Seeing this error even if remove
objectFit?: Property.ObjectFit;
which seems like one of the only items related.Resolves: #1738
Release Category
Components:
Avatar.tsx
Checklist
Will do the following once have a more stable branch!
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Typically, you would test in storybook by going to the Avatar Component and adjusting with the stories. Unfortunately storybook isn't currently loading with the current config.
Thank You Gif