Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Avatar to use createStencil and createComponent #2783

Closed
wants to merge 1 commit into from

Conversation

kaconant
Copy link
Contributor

@kaconant kaconant commented Jun 15, 2024

Summary

Starting to refactor the Avatar component to use the new createStencil and createComponent conventions.

Currently a WIP as these changes break the build - getting the following error:

ERROR in ./modules/react/avatar/lib/Avatar.tsx. Module build failed (from ./.storybook/style-transform-loader.js): Error: Unknown type at: "Property.AlignContent". Received "AlignContent"

Seeing this error even if remove objectFit?: Property.ObjectFit; which seems like one of the only items related.

Resolves: #1738

Release Category

Components: Avatar.tsx


Checklist

Will do the following once have a more stable branch!

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

  • Review to see if direction is right. Currently working with @mannycarrera4.

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Typically, you would test in storybook by going to the Avatar Component and adjusting with the stories. Unfortunately storybook isn't currently loading with the current config.

Thank You Gif

a turtle and hare racing

@kaconant kaconant closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild Avatar component
1 participant