CJ4: 0.4.1 prerelease

[dga711]

Fix Bugs!

TODO
Things we don't fix here we should create issues for after release

• Changelog
• Fix direct to IAF from LEGS / closes CJ4: Legs and Progress page random (dis)appearance of WPTs #220
• Fix approach waypoint display in FMS Text / closes CJ4: Legs and Progress page random (dis)appearance of WPTs #220
• Fix distances in PROG/MFD / closes CJ4: Progress page showing wrong distance to destination #232
• Actually show errors when user inputs invalid waypoints
• Smoother AP / closes CJ4 Oscillation in flight #163
• Add Magenta to TO fix on PROG
• Reverse CROSSWIND L/R for tailwind situations on PROG2
• Flight Dynamics set elevator_trim_effectiveness back to 1.5
• Fix engines off thrust / closes CJ4: Aircraft Moving off When Parke Brake is released (without the engines running) #222
• Fix MFD plane on map not centered / closes CJ4: MFD not centered on aircraft #219
• Fix VSpeed -1 / closes CJ4: Takeoff V-speeds do not display on PFD after first flight #221
• Fix approach waypoint display in LEGS / closes CJ4: Legs and Progress page random (dis)appearance of WPTs #220
• Fix indexof when adding airways / closes CJ4: FPLN does not add the complete airway #226 / credit @tscharlii for it
• Added input filters for QNH on takeoff and landing perf pages
• Fixed PITOT, OXY MASK and PARKING BRAKE CAS Messages / closes CJ4: Constant warning with PITOT / STATIC Heat on #242 / closes CJ4 v0.3.1: Use Oxygen mask at above FL440 #183
• Added protection to Takeoff Ref and Approach Ref pages for missing departure or arrival runway
• Fix Perf Init weight issues / closes CJ4 Weight seem to be incorrectly calculated #241

Audio (still on another branch)

• Need Chime when playing seatbelt announcement
• Chimes are played when setting battery master to on
• Need to set States correctly for the groups so sounds dont stop when going external view and back in. See https://discordapp.com/channels/750764704175226992/764122525323362325/764904295618969600
• Add passenger briefing announcements
• Restrict only one announcement to play at once
• Improvements to climate control knob sound
• Fix passenger sounds stopping when switching to outside view
• Fix chime playing when battery is turned on

[tscharlii]

Regarding 5579a87

A simple equality check does not work. Note the fixed length format of airway.icaos. It's not just a list of identifiers, but contains more information.
Index 0: Type (A=Airport, V=VOR, W or I = Waypoint or Intersection, etc.)
Index 1 and following: I assume that's the region
Index 7, 8, 9, 10, 11: Identifier, padded with spaces for shorter than 5 character waypoints

airway.icaos = ["VEB    NIK  ","WEB    DENUT","WEB    LUMEN","WEB    BULAM","WEB    DIBLI","WEG    RAPIX","WEG    SUNUP","WEG    TEBRA","WEG    KOPUL","WEG    UNSAD","WEG    NILON","WEG    GILDA","VEG    LAM  ","WEG    HEMEL","WLT    EKSEN","WLT    EKMIM","WLT    UPKUL","WLT    EMKUD","WLT    OSGED","WLT    PESOX","WLT    SIVKU","WLT    APSER","WLT    ETAMP","WLT    EMGIM","VLT    YAA  ","VLT    IST  ","WLT    FENER","WLB    VADEN","WLY    UTEKA","WLY    DONIV","WLY    PELOV","WLY    TISAK","WLY    TONDO","WED    RENKA","WED    GONBA","WED    STAUB","WED    MAMOR","WED    UNKUL","WED    UPALA","WED    INBED","WED    AMOSA","WED    IBAGA","WED    BARSU","WED    KOMIB","WED    TUSOS","WED    BIBEG"]

With the following code in line 448, I was able to add the NIK -> L610 -> LAM airway

let lastWaypointIcao = airway.icaos.find(icao => icao.substring(7, 12) === lastWaypointIdent.padEnd(5, " "));

[tscharlii]

Duplicate comment. Removed.

[dga711]

Regarding [5579a87]

@tscharlii i see. i switched up icao and ident and didnt properly look into it because it was late ^^
i will check again and look into the vars while debugging. thanks for the heads up.
everything you have to do with waypoints feels like a hack job ;)