Upgrade deps for Dart 3 #432
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
dart_dependency_validator.yaml
Outdated
| @@ -1,2 +1,3 @@ | |||
| exclude: | |||
| - test/tools/fixtures/organize_directives/directives.dart | |||
| - test/tools/fixtures/analyze/failing/failing.dart | |||
There was a problem hiding this comment.
This is an invalid dart file (intentionally for tests) but causes the analyzer to throw when running dependency validator (looking for import statements). Added to the exclude list to avoid dependency validator breaking in CI.
There was a problem hiding this comment.
Thoughts on updating this to: test/**/fixtures/**.dart to mirror what we have in the dart_dev config? https://github.com/Workiva/dart_dev/blob/master/tool/dart_dev/config.dart#L9
| lints: '>=1.0.1 <3.0.0' | ||
| build_runner: ^2.0.0 | ||
| dependency_validator: ^4.0.0 | ||
| lints: '>=2.0.0 <5.0.0' |
There was a problem hiding this comment.
Update dependencies to allow Dart 3 versions of packages
| @@ -1,4 +1,5 @@ | |||
| @TestOn('vm') | |||
| @Tags(['dart2']) | |||
There was a problem hiding this comment.
This test explodes on Dart 3 because there are @dart=2.9 comments that don't work in Dart 3. The lowest version you can use in a comment like that in Dart 3 is 2.12 (null safety).
dart_dependency_validator.yaml
Outdated
| @@ -1,2 +1,3 @@ | |||
| exclude: | |||
| - test/tools/fixtures/organize_directives/directives.dart | |||
| - test/tools/fixtures/analyze/failing/failing.dart | |||
There was a problem hiding this comment.
Thoughts on updating this to: test/**/fixtures/**.dart to mirror what we have in the dart_dev config? https://github.com/Workiva/dart_dev/blob/master/tool/dart_dev/config.dart#L9
|
QA+1 CI passes on Dart 3 latest @Workiva/release-management-p |
Summary
We want this package to be fully able to run on Dart 3, while being backwards compatible with 2.19 for now.