CPLAT-935 Add PureComponentMixin #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
+ And a custom Equality that is safe for ReactElement / Function() as props / state values in dart2js
aaronlademann-wf
changed the title
greglittlefield-wf
requested changes
Jul 2, 2020
aaronlademann-wf
force-pushed
the
pure-ui-component
branch
from
f1c3da2
to
1197fa8
Compare
aaronlademann-wf
force-pushed
the
pure-ui-component
branch
from
1197fa8
to
7d356bc
Compare
greglittlefield-wf
requested changes
Jul 16, 2020
+ To avoid conflicts with many pre-existing implementations in consumer libs + And export from over_react.dart instead of component.dart
aaronlademann-wf
changed the title
+ Becaues otherwise, `propTypes` cannot be overridden without analysis issues for components mixing in PureComponentMixin
| /// Main entry point for `PureComponentMixin` testing | ||
| main() { | ||
| group('PureComponentMixin', () { | ||
| const initialChildren = ['initial']; |
There was a problem hiding this comment.
Looks like we're only testing prop updates here. Should we also be testing the effect of state updates/non-updates?
There was a problem hiding this comment.
Probably not a huge deal since the implementation is the same as for props 🤷
There was a problem hiding this comment.
There is a test at the very beginning that uses forceUpdate
There was a problem hiding this comment.
Ah, I see it now 👍
corwinsheahan-wf
approved these changes
Jul 16, 2020
|
@Workiva/release-management-p |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Consumers sometimes ask how to use
React.PureComponentwithOverReact.Changes
PureComponentMixinwhich will cause a component to behave likeReact.PureComponent.Release Notes
Add
PureComponentMixinto allow consumers to create components that mimicReact.PureComponentbehavior.Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @greglittlefield-wf @kealjones-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: