-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-11863 Add Redux Hooks #674
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
f8616a8
to
ba776c1
Compare
ba776c1
to
510d2bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some comments, but this looks awesome!! I'm so excited for these hooks to be available!
e91e6af
to
7af57fc
Compare
@greglittlefield-wf all feedback has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks really good to me - the nesting on those hooks does not look fun haha. I only found nits!
7af57fc
to
ebc43f9
Compare
All feedback addressed @joebingham-wk! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more small things
@greglittlefield-wf all feedback addressed. |
QA +1 @Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
The react-redux JS package that we wrap / expose from our
over_react_redux.dart
library offers function component hook APIs that we don't have wrapped for our consumers.Core Changes
useSelector
,createSelectorHook
,useDispatch
,createDispatchHook
,useStore
andcreateStoreHook
top level functions, along with the necessary JS interop pieces to call into the analogous JS hooks.Misc Changes
src/
so we can reuse some of it in ourexample/
sRelease Notes
Add React Redux hooks for function components