CPLAT-11863 Add Redux Hooks #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
force-pushed
the
react-redux-hooks
branch
3 times, most recently
from
f8616a8
to
ba776c1
Compare
aaronlademann-wf
force-pushed
the
react-redux-hooks
branch
from
ba776c1
to
510d2bd
Compare
aaronlademann-wf
requested review from
joebingham-wk,
sydneyjodon-wk and
greglittlefield-wf
greglittlefield-wf
requested changes
Jan 21, 2021
aaronlademann-wf
force-pushed
the
react-redux-hooks
branch
2 times, most recently
from
e91e6af
to
7af57fc
Compare
|
@greglittlefield-wf all feedback has been addressed. |
aaronlademann-wf
force-pushed
the
react-redux-hooks
branch
from
7af57fc
to
ebc43f9
Compare
|
All feedback addressed @joebingham-wk! |
greglittlefield-wf
requested changes
Jan 29, 2021
|
@greglittlefield-wf all feedback addressed. |
greglittlefield-wf
approved these changes
Jan 29, 2021
|
QA +1 @Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The react-redux JS package that we wrap / expose from our
over_react_redux.dartlibrary offers function component hook APIs that we don't have wrapped for our consumers.Core Changes
useSelector,createSelectorHook,useDispatch,createDispatchHook,useStoreandcreateStoreHooktop level functions, along with the necessary JS interop pieces to call into the analogous JS hooks.Misc Changes
src/so we can reuse some of it in ourexample/sRelease Notes
Add React Redux hooks for function components