Upgrade built_value_generator to v8 #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
This involves: - Upgrading built_value_generator to ^8.0.0 - Upgrading built_value to ^8.0.0 - Upgrading built_collection to ^5.0.0 - Updating built assets
sourcegraph-wk
force-pushed
the
batch/cplat/built_value_generator_v8
branch
from
344767a
to
730522b
Compare
|
FYI the build_runner command in the PR description is not quite right, it should be: |
|
I ran build_runner build in both the root of the package and in the todo_client in the app directory. No files were updated in either locations. I couldn't find any other places there might be built_value code to generate. 🤞 |
robbecker-wf
approved these changes
Feb 11, 2022
greglittlefield-wf
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Client Platform is updating dependencies! Read more details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades
This PR is the last step in the process to upgrade to built_value_generator
v8. At this point, all packages at Workiva are compatible with built_value
v8 and built_collection v5, so this PR upgrades the generator from v7 to v8
and commits the updated assets from it.
Note that because code generated by built_value_generator v8 uses APIs that
are only available in built_value v8 and built_collection v5, this PR also
raises the minimums of those dependencies accordingly.
TODO
dart build_runner buildand commit updated generated assets.Testing
For most consumers, static analysis along with existing unit and functional
tests should provide adequate coverage of these changes. We are already
using built_value v8 and built_collection v5 in Wdesk; this PR just upgrades
the generated code that uses those libraries to the same version.
For more info, reach out to
#support-client-platon Slack.Created by Sourcegraph batch change
Workiva/built_value_generator_v8.