-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade built_value_generator to v8 #729
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
This involves: - Upgrading built_value_generator to ^8.0.0 - Upgrading built_value to ^8.0.0 - Upgrading built_collection to ^5.0.0 - Updating built assets
344767a
to
730522b
Compare
FYI the build_runner command in the PR description is not quite right, it should be:
|
I ran build_runner build in both the root of the package and in the todo_client in the app directory. No files were updated in either locations. I couldn't find any other places there might be built_value code to generate. 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Summary
Client Platform is updating dependencies! Read more details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades
This PR is the last step in the process to upgrade to built_value_generator
v8. At this point, all packages at Workiva are compatible with built_value
v8 and built_collection v5, so this PR upgrades the generator from v7 to v8
and commits the updated assets from it.
Note that because code generated by built_value_generator v8 uses APIs that
are only available in built_value v8 and built_collection v5, this PR also
raises the minimums of those dependencies accordingly.
TODO
dart build_runner build
and commit updated generated assets.Testing
For most consumers, static analysis along with existing unit and functional
tests should provide adequate coverage of these changes. We are already
using built_value v8 and built_collection v5 in Wdesk; this PR just upgrades
the generated code that uses those libraries to the same version.
For more info, reach out to
#support-client-plat
on Slack.Created by Sourcegraph batch change
Workiva/built_value_generator_v8
.