Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dart_ci.yml #53

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Update dart_ci.yml #53

merged 1 commit into from
Oct 20, 2022

Conversation

kealjones-wk
Copy link
Contributor

@kealjones-wk kealjones-wk commented Oct 20, 2022

Motivation

The Upload & Report Unit Test Results CI steps are wack.
see: Workiva/over_react_codemod@1cde45f

Changes

  • Removed Upload and Report Unit Test Results CI Steps

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@kealjones-wk kealjones-wk requested review from a team and sydneyjodon-wk and removed request for a team October 20, 2022 22:52
@greglittlefield-wf
Copy link
Contributor

CI is passing

QA +1

@Workiva/release-management-p

@kealjones-wk
Copy link
Contributor Author

@Workiva/release-management-p

@kealjones-wk kealjones-wk merged commit 5bedb4f into master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants