Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix teams paths and chat response sanitization #789

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix teams paths and chat response sanitization #789

merged 4 commits into from
Aug 21, 2024

Conversation

aperez-worklytics
Copy link
Contributor

Following #774

  • Tokenize chatId on response, as it is on the request
  • Fixing name of the rules to match no app ids
  • Fix odataType, which should be present, for chat messages

Fixes

Fix Teams paths

Features

paste links to issues/tasks in project management

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes?
    • NOTE in CHANGELOG.md anything that will show up in terraform plan/apply that isn't
      obviously a no-op? no
    • breaking changes? if in module/example that is NOT marked alpha, requires major version
      change

@aperez-worklytics aperez-worklytics self-assigned this Aug 21, 2024
@eschultink eschultink merged commit 0fee029 into rc-v0.4.59 Aug 21, 2024
38 checks passed
@eschultink eschultink deleted the fix_teams_paths branch August 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlorper jlorper jlorper approved these changes

@eschultink eschultink Awaiting requested review from eschultink

Assignees

@aperez-worklytics aperez-worklytics

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aperez-worklytics @jlorper @eschultink