This repository has been archived by the owner on Oct 24, 2018. It is now read-only.
Configurable argument #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently each generated method accepts a lot of object.
generally it has no problem, but it would be bad when we have
a lot of argument in controller.
So, we make it configurable to allow new argument interface like below:
generatedJavascript.someMethod({
foo: 'foo',
bar: 'bar',
num: 0
});
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To write readable code, current interface for argument is not ideal. Now we start supporting new interface like
api.method({"foo": foo, "bar": bar}).To keep backward compatibility, we need to make it configurable. I made an enum to implement it.