Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use automatic version numbers #22

Closed

Conversation

costateixeira
Copy link
Collaborator

Just learned that the template does that automatically, so we don't need to maintain the version on each artifact

@costateixeira
Copy link
Collaborator Author

@ritikarawlani you can merge. don't mind the repo name change in the readme, it will be updated automatically

Copy link
Collaborator

@ritikarawlani ritikarawlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@costateixeira please resolve comments

@@ -30,3 +30,5 @@ dependencies:
who.ddcc: dev
who.ips-pilgrimage: dev

# parameters:
# apply-version: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@costateixeira please also upgrade the version to 1.1.1 with this change and describe change in publication-request json

@litlfred
Copy link
Collaborator

anything to do here @costateixeira @ritikarawlani ?

Copy link
Collaborator Author

@costateixeira costateixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented out text

@litlfred
Copy link
Collaborator

in main, the models were moved to input/fsh/models and edited a bit.  that's causing a merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants