Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qtpy dependency optional #376

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

Carifio24
Copy link
Member

@Carifio24 Carifio24 commented May 14, 2024

Downstream in glue-wwt we're trying to make qtpy be an optional dependency (glue-viz/glue-wwt#111) so that it doesn't need to be installed to use the WWT Jupyter viewer. To help make that possible, this PR makes qtpy an optional dependency of pywwt, moving it to the qt and qt6 install options.

The documentation already makes it sound like qtpy is an optional dependency, so I don't think it needs to be changed at all?

@Carifio24
Copy link
Member Author

CI failures are the same as in #375; I can rebase once we finish sorting that out.

@pkgw
Copy link
Contributor

pkgw commented May 17, 2024

Looks like you'll need to rebase to make ReadTheDocs happy.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (5ec4686) to head (22117b7).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          25       25           
  Lines        2872     2872           
=======================================
  Hits         1623     1623           
  Misses       1249     1249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkgw pkgw merged commit 8fcaff9 into WorldWideTelescope:master May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants