Moved solar system settings to proxy object #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I edited the docs to to reflect the proxy object. I also enabled solar system lighting after testing it and being able to toggle it without issue -- both true and false worked. Are you two (cc @philrosenfield) still having problems with it? |
astrofrog
requested changes
Apr 30, 2018
docs/views.rst
Outdated
|
|
||
| Panorama view | ||
| ------------- | ||
| **Keep or no?** |
There was a problem hiding this comment.
Is there any harm in keeping this for now?
There was a problem hiding this comment.
I don't think so. My knowledge of it is just incomplete because I'm not sure what the mode-specific controls are. I attempted to address this in the new commit.
pywwt/ss_proxy.py
Outdated
|
|
||
| class SolarSystem(HasTraits): | ||
|
|
||
| def __init__(self, BaseWWTWidget): |
There was a problem hiding this comment.
I would avoid using BaseWWTWidget here as that is the class name (not the instance) - instead use base_wwt_widget
astrofrog
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it OK that tab-completion also shows the inherited methods from traitlets'
HasTraitalong with the solar system traits?Edits to the docs are upcoming.