Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck animations/sounds when casting spells #104

Closed
arm358 opened this issue Nov 21, 2022 · 29 comments
Closed

Stuck animations/sounds when casting spells #104

arm358 opened this issue Nov 21, 2022 · 29 comments

Comments

@arm358
Copy link

arm358 commented Nov 21, 2022

Describe the bug
When casting a spell, sometimes the casting animation (hands glowing) and casting sound will get stuck "on" and not clear. The only fix is a relog (reload does not clear it).
Can be reproduced most easily by spamming Inner Fire (Rank 1). Seems to happen when trying to cast a spell during GCD.

IMG_6253.mov

Game Version
Using Brotalnia's guide for 1.14 client, but launching Arctium through Steam Proton Experimental
Connection to Everlook
Screenshot from 2022-11-21 07-40-10

Hermes Proxy Version
Latest release for Linux Ubuntu (v3.2 b0dcbb8)

@Lihvar
Copy link
Contributor

Lihvar commented Nov 23, 2022

This is due to server to proxy(and vice versa) lag/latency. I've added a "fix" for it in my own branch, to induce a manual delay to proxy to avoid this

@arm358
Copy link
Author

arm358 commented Nov 23, 2022

@Lihvar thanks - I tried your version but I am getting FAIL_VERSION_INVALID error which I was getting before the latest HermesProxy release.

Connecting to Everlook

Screenshot from 2022-11-23 07-13-05

@0blu
Copy link
Collaborator

0blu commented Nov 23, 2022

Is the spell bug also appearing when you toggle the "Optimize for Network speed" option in the game settings?

@arm358
Copy link
Author

arm358 commented Nov 23, 2022

Yes -- i have had that option enabled throughout my testing.

@Lihvar
Copy link
Contributor

Lihvar commented Nov 23, 2022

I've just updated my version, merging from WoWLegacyCore, you set the delay in the config file, its pretty much testing values and seeing what works, my suggestion is first try 30 for both server and client delay, see how it works, and if it doesn't then I'd suggest increasing Server delay until you find a value that works, its a crude "fix" for a delay in communication between server and the proxy

@arm358
Copy link
Author

arm358 commented Nov 23, 2022

I've just updated my version, merging from WoWLegacyCore, you set the delay in the config file, its pretty much testing values and seeing what works, my suggestion is first try 30 for both server and client delay, see how it works, and if it doesn't then I'd suggest increasing Server delay until you find a value that works, its a crude "fix" for a delay in communication between server and the proxy

Thanks Lihvar - I just downloaded your version (for Ubuntu) and I'm still getting the same "Your version is not supported by this server" error. I do not get that issue when using WoWLegacyCore HermesProxy.

@Lihvar
Copy link
Contributor

Lihvar commented Nov 23, 2022

I see, tested it myself just now on Everlook and yeah it doesnt accept my fork, its due to versioning and I dont have time to fix that today unfortunately

@blackcorridors
Copy link

Anything on this?
This is a pretty big issue and requires either relogging every time it happens, or playing with no sound as a quasi-fix.

@Lihvar
Copy link
Contributor

Lihvar commented Nov 26, 2022

I know, its super annoying, I've updated my version but Everlook only allows the official WoWLegacyCore version

@blackcorridors
Copy link

I know, its super annoying, I've updated my version but Everlook only allows the official WoWLegacyCore version

Thank you, hopefully the official version gets updated soon with the fix.

@0blu
Copy link
Collaborator

0blu commented Nov 27, 2022

I still can't reproduce this. Not on everlook nor on my local server.
I don't know why an artificial delay fixes this, but it is probably not to be the correct solution.

This is a TCP stream the packets are always in the same order.

@Lihvar
Copy link
Contributor

Lihvar commented Nov 27, 2022

It is not real fix I know, but it worked for me, I tried figuring out a real fix and just didn't have the time and expertise.
But the way I can reproduce this 100% of the time is:

  • Run SPP(Single Player Project, aka cmangos with bots and the reason behind this is bots which can produce server lag) on a Server PC(separate from Client PC)
  • Run HermesProxy from the Server PC as well(NOT CLIENT PC), the settings in Hermes then would be ServerAddress is localhost and ExternalAddress the IP of the Server(in my case 192.168.1.X)
  • In SPP settings put like 5000 bots to make sure the server will lag and then just try playing. If I do it like this I get this problem all the time(without artificial delays)

@0blu
Copy link
Collaborator

0blu commented Nov 27, 2022

Okay my setup looks like this

---------------
|    SPP      |              --------------
|   Hermes    | <-- Wifi --> | WoWClassic |
---------------              --------------

I set

AiPlayerbot.MinRandomBots = 9000
AiPlayerbot.MaxRandomBots = 9000

In game in human start zone I did

.learn 588 // Inner Fire
.mod mana 9999999

and spammed Inner Fire.

The server was lagging hard, spells and commands took 3 seconds to register.
I was unable to reproduce the bug.

@Newfriendfromwinter
Copy link

Newfriendfromwinter commented Nov 27, 2022

Me and my guildmate are also experiencing this issue on Everlook. I've had it occur multiple times with the spell Rockbiter Weapon.

@Lihvar
Copy link
Contributor

Lihvar commented Nov 27, 2022

How, I get it every single time when the server is lagging and Im even connected via LAN not WiFi. That is super strange

@Fearyii
Copy link
Contributor

Fearyii commented Nov 28, 2022

@0blu I am having this issue playing on Everlook as well happends a lot on casts like frost nova or drinking/eating food. I am connected to LAN as well my internet speed is like 120+ mbps so its not an internet issue

@arm358
Copy link
Author

arm358 commented Nov 28, 2022

@0blu I am having this issue playing on Everlook as well happends a lot on casts like frost nova or drinking/eating food. I am connected to LAN as well my internet speed is like 120+ mbps so its not an internet issue

i am in NA and i think it has to do with the ping to the server on France. 1.14 shows 0ms delay between proxy and client but when i load up the 1.12 client directly i get about 120-150ms delay.

@ratkosrb
Copy link
Collaborator

That's cause it shows you ping to the proxy, not to the server, since you are not connected directly to the server. I think Blu made a commit to fix that recently.

0blu pushed a commit that referenced this issue Nov 28, 2022
@tronics-glitch
Copy link

This is really game/immersion breaking, please fix.

@MaxtorCoder
Copy link
Contributor

Use latest version of HermesProxy, should be fixed.

@tronics-glitch
Copy link

I just updated and it isn't, that's what made me post

@0blu
Copy link
Collaborator

0blu commented Nov 29, 2022

You have to go into the HermesProxy.config and change it to something like this

    <add key="ServerSpellDelay" value="50" />
    <add key="ClientSpellDelay" value="50" />

@MaxtorCoder
Copy link
Contributor

Maybe good to assign default values @0blu

@Lihvar
Copy link
Contributor

Lihvar commented Nov 29, 2022

I suggest to people trying different values and seeing what works, from personal experience values between 20-80 were good, going over 80 there is gonna be a noticeable delay

@tronics-glitch
Copy link

So this adds latency on purpose to prevent the issue? I already play with like 200ms

@0blu
Copy link
Collaborator

0blu commented Nov 29, 2022

Yes, a delay is added, since we don't know what the real reason for this issue is.
So if you are really keen for DPS you should set it to 0.
But for questing values from 20-80 seem to be okay.

@tronics-glitch
Copy link

I put values at 20 and so far I didn't see issue again. Thanks!

@arm358
Copy link
Author

arm358 commented Nov 30, 2022

Fixed for me with values at 20 for each variable. Also noticed this made gameplay lag/delay much better as well not just for spells but for shooting wands, fear, etc. Thank you for this!!!!

@0blu
Copy link
Collaborator

0blu commented Dec 1, 2022

Do you have to set both variables to 20 or is it possible to just set one?

kelno pushed a commit to kelno/HermesProxy that referenced this issue Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants