Added setting in Programs plugin to hide suffix description #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramen Bless Your Repo
Thanks for a great app - heres a danish translation!
* Fixed HideOnStartup * Fixed tray icon not showing up and hiding properly
… 6.1). (Wox-launcher#817) Added check before applying blur.
…cher#856) * Fixed SearchSource edit * Remove temp var
…cher#856) * Fixed SearchSource edit * Remove temp var
lock is not needed since assignment is atomic
Added German and Danish language support
since Yamp is not maintained anymore, replaced with Mages
- does not steal focus from main Wox window on Show - TextBlock sizes are set to auto and expand vertically - locations for animations are set at Loaded event instead of constructor call. This ensures that all elements have their sized calculated - added duration parameter to Show. Msg will display indefinitely if no parameter is passed and will close itself after the specified duration. This is not replicated in the public plugin API therefore all Msg.Show calls from plugins will be open until manually closed.
Plugin errors on initialization are catched, saved into a list and the user is notified that the plugins have been disabled. Uses Msg window to show the plugins that did not load correctly. Added english language strings
The goal is to encourage translation.
lances101
reviewed
Jan 12, 2018
| private void ShowDescription_Click(object sender, RoutedEventArgs e) | ||
| { | ||
| _settings.EnableShowDescription = ShowDescription.IsChecked ?? false; | ||
| ReIndexing(); |
There was a problem hiding this comment.
Why are you reindexing here? Showing the description or not is purely visual.
Edit: Okay. Found out why you are doing it. I am not saying its the worst way to do this, but I will have to take a look later, cause it feels kinda hacky in my opinion.
|
Yes, thought of asking you about it, but didn't really know how. If you get a better way to "refresh" let me know. |
bao-qian
force-pushed
the
dev
branch
4 times, most recently
from
623cea6
to
7e3a30c
Compare
bao-qian
force-pushed
the
dev
branch
2 times, most recently
from
dec7252
to
c0c6f8e
Compare
|
hi @lSindra, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1388
What it does:
Allow the user to hide the second part of the Program name.
Example
from: "Google Chrome: Access the Internet"
to: "Google Chrome"