Additional user functionality noted in Issue #6 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqharris
reviewed
Feb 4, 2021
| recall_by_model <- function(model, | ||
| start_year = NULL, end_year = NULL, | ||
| limit = 25, | ||
| partial = FALSE) { |
There was a problem hiding this comment.
no, it's currently a placeholder related to filtering the output dataframe which @RyKoe should be implementing (call to API returns all partial matches no matter what)
RyKoe
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be merged in now, or can wait until other PRs are merged in, not sure which order is better.
This adds the additional user functionality noted in issue #6 including:
recall_by_make()orrecall_by_model()output data related to the list of inputsrecall_details()to handle an input list of numbers that queries the API multiple times and returns a dataframe of the outputcall_vrd_api()