Added support for serde's 'rename_all' attribute #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @thebluefish , thanks a lot for your work here and sorry I've taken so long to look at it. It's great that you've thought of the backwards-compatible approach here but I think we should get rid of the old attribute altogether. I'll merge this in and add a quick patch for that. We'll consider this a breaking change and bump to tsync 2.0 so end-users know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serde 1.0 throws an error when attempting to use the
renameAllattribute per tests:This adds support for the
rename_allattribute according to https://serde.rs/container-attrs.htmlI originally changed just the tag, removing support for
renameAll, but I added a separate check in case the other tag is used somewhere I'm not aware of.