Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu 22.1.0 #75

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

waywardmonkeys
Copy link
Contributor

This changes a lifetime for scoped render pipelines to match a similar change for begin_render_pass in wgpu itself.

@waywardmonkeys
Copy link
Contributor Author

Hmm, that's an interesting build failure.

@waywardmonkeys
Copy link
Contributor Author

This failure is due to gfx-rs/wgpu#5988

@Wumpf
Copy link
Owner

Wumpf commented Jul 19, 2024

Thanks for opening this! Looks like we'll have to wait for 22.1 though or remove the tracy feature for a release 🤔

Since there's already so many people knocking to move forward, I'd say we create an issue about this here to track it and remove tracy and then readd it once there's a wgpu patch release out at which point yet-another wgpu-profiler version releases

@John-Nagle
Copy link

Don't remove Tracy support! The whole point of this crate is profiling. I need this upgrade so I can look for known performance bugs using a later WGPU. If I report performance bugs for any WGPU other than the very latest, the maintainers want the problem reproduced on the "current version".

@cwfitzgerald
Copy link
Contributor

I think we should do a patch release pretty soon, there's a few things that need to be patched

@Wumpf
Copy link
Owner

Wumpf commented Jul 20, 2024

the maintainers want the problem reproduced on the "current version"

ahh these annoying wgpu maintainers 😅
Yeah, let's get a wgpu patch out there in a timely fashion then instead 👍(:

@waywardmonkeys
Copy link
Contributor Author

Sounds good to me, happy to wait a bit.

@waywardmonkeys waywardmonkeys force-pushed the update-to-wgpu-22 branch 2 times, most recently from 3ef0e33 to ddd7062 Compare August 1, 2024 01:53
@waywardmonkeys waywardmonkeys changed the title Update to wgpu 22.0.0 Update to wgpu 22.1.0 Aug 1, 2024
@waywardmonkeys
Copy link
Contributor Author

Updated for 22.1.0!

I didn't update all of the stuff ... so maybe that should happen after this and before the release. Just an update to Cargo.lock, I think.

@John-Nagle
Copy link

version = "0.17.0"

Needs a version bump so it can be pushed to crates.io.

@waywardmonkeys
Copy link
Contributor Author

Assuming this is about the crate version and not tracy-client version ... that would happen as part of a PR for the new version / publish.

I should add a CHANGELOG entry though to this commit to make that easier.

This changes a lifetime for scoped render pipelines to match
a similar change for `begin_render_pass` in wgpu itself.
@Wumpf Wumpf merged commit 9fa6eeb into Wumpf:main Aug 1, 2024
1 check passed
@Wumpf
Copy link
Owner

Wumpf commented Aug 1, 2024

done so directly on main now and published a new version to crates.io

@waywardmonkeys waywardmonkeys deleted the update-to-wgpu-22 branch August 1, 2024 08:06
@waywardmonkeys
Copy link
Contributor Author

Thank you!

@DJMcNab
Copy link

DJMcNab commented Aug 1, 2024

Should that release have a corresponding tag as well?

@Wumpf
Copy link
Owner

Wumpf commented Aug 1, 2024

ah yes, forgot about that, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WGPU just went to version 22.0.0.
5 participants