-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce thread/statefulness of current dumping solution #16
Draft
Wunkolo
wants to merge
8
commits into
master
Choose a base branch
from
feat/dump-thread
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearTargetThread seems to be almost "Too fast" at times when dumping small programs and will unknowingly get UWPInjector to timeout
Add diagnostic data around remote thread based dumping
Wunkolo
force-pushed
the
feat/dump-thread
branch
from
March 7, 2019 09:56
17a1579
to
f9d0fcd
Compare
Closed
might I ask why this fork has not been merged in? |
It is still in development and is not exactly merge-ready, and simply encapsulates a possible re-paradigm of the current dumping pattern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #13:
This is to optimize the dumping path into something more stable and generic across games that would hit less of the commonly-mitigated methods.
Less threads, less IPC-statefulness or dependency, and hopefully making the DLL more independent so that you wouldn't even have to use UWPInjector if you didn't want to.