Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup API #47

Merged
merged 21 commits into from
Mar 24, 2021
Merged

Signup API #47

merged 21 commits into from
Mar 24, 2021

Conversation

adefemi171
Copy link
Contributor

@adefemi171 adefemi171 commented Mar 6, 2021

@adefemi171 adefemi171 added area/backend Related to backend WIP Work In Progress labels Mar 6, 2021
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #47 (92b6ed7) into master (f66e1ab) will increase coverage by 9.02%.
The diff coverage is 69.81%.

❗ Current head 92b6ed7 differs from pull request most recent head 2d600c8. Consider uploading reports for the commit 2d600c8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   58.62%   67.64%   +9.02%     
==========================================
  Files           3        5       +2     
  Lines          29       68      +39     
==========================================
+ Hits           17       46      +29     
- Misses          9       17       +8     
- Partials        3        5       +2     
Impacted Files Coverage Δ
src/backend/internal/controllers/controller.go 0.00% <0.00%> (ø)
src/backend/internal/models/user.go 66.66% <66.66%> (ø)
src/backend/internal/controllers/user.go 71.79% <71.79%> (ø)
src/backend/internal/models/roles.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db3b29...2d600c8. Read the comment docs.

@adefemi171 adefemi171 linked an issue Mar 11, 2021 that may be closed by this pull request
var ValidationErrors = []string{}

//HandleErr //generic error handler, logs error and Os.Exit(1)
func HandleErr(c *gin.Context, err error) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adefemi171 How do you plan to use the Err handler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to use it for db errors, but will remove it from the code

simplytunde
simplytunde previously approved these changes Mar 20, 2021
@simplytunde simplytunde changed the title WIP : Signup API Signup API Mar 24, 2021
@simplytunde simplytunde removed the WIP Work In Progress label Mar 24, 2021
@simplytunde simplytunde merged commit 7e9dc43 into master Mar 24, 2021
@simplytunde simplytunde deleted the signup-api branch March 24, 2021 18:23
@simplytunde simplytunde mentioned this pull request Mar 26, 2021
@wuralab-bot wuralab-bot mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Related to backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Employee Signup API Login API
5 participants