Extract common functionality from Features #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0keDev
reviewed
May 17, 2022
P0keDev
reviewed
May 17, 2022
kristofbolyai
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've looked through all Features (except ItemStatInfoFeature which deserves separate treatment), and extracted functionality that is not super tightly tied to that Feature into common Util classes. I've not tried too hard at this point to generalize the functionality, or to put it in the right spot, but just to increase visibility for the functionality.
Two such methods were similar enough that I decided to merge them. But this was a bit tricky and I decided to leave out any further such generalizations from this PR.
The guiding star for this change has once again been that the features should read like natural language, describing what they do in terms of wynncraft and minecraft "DSL" APIs. I think this has mostly succeeded, in that the Features contain more or less the exact amount of knowledge. What is still missing is shaping up these APIs. They are quite ad-hoc right now, a bunch of util methods roughly grouped per area.
I've also rewritten the emerald pouch search logic in EmeraldPouchHotkeyFeature, and refactored a bit wrt McUtil.