Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ygr avsr #13

Closed
wants to merge 8 commits into from
Closed

Ygr avsr #13

wants to merge 8 commits into from

Conversation

yanghaha0908
Copy link
Collaborator

add log&wandb

@@ -33,8 +34,33 @@ class custom_dataset:
train_split: str = "train"
test_split: str = "validation"
data_path: str = NotImplemented
max_words: int = NotImplemented
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication

TRAIN_LRS3_MODEL_FILE: str = "/nfs/yangguanrou.ygr/AVSR/train-step_0108-wer_0.058.ckpt" # "/home/oss/yangguanrou.ygr/AVSR/train-step_0108-wer_0.058.ckpt" #单一模态是这个
TRAINED_AO_FILE : str = "/nfs/yangguanrou.ygr/AVSR/check/train-step_0604-wer_0.054.ckpt" #"/home/oss/yangguanrou.ygr/AVSR/check/train-step_0604-wer_0.054.ckpt"
TRAINED_VO_FILE: str = "/nfs/yangguanrou.ygr/AVSR/check/train-step_1191-wer_0.674.ckpt" #"/home/oss/yangguanrou.ygr/AVSR/check/train-step_1191-wer_0.674.ckpt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can customize each model config, instead of merge all model together.
@LauraGPT Can this be resolved with hydra?

@@ -222,7 +222,7 @@ def main(**kwargs):
lr=train_config.lr,
weight_decay=train_config.weight_decay,
)
scheduler = StepLR(optimizer, step_size=1, gamma=train_config.gamma)
scheduler = StepLR(optimizer, step_size=1/root/SLAM-LLM/src/llama_recipes/models, gamma=train_config.gamma)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix

logger.info("model_config: {}".format(model_config))



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clean up

[2023-12-15 16:38:36][root][INFO] - --> Training Set Length = 280879
[2023-12-15 16:38:36][root][INFO] - --> Validation Set Length = 2864
[2023-12-15 16:38:36][llama_recipes.utils.config_utils][INFO] - Using batching strategy: custom
[2023-12-15 16:38:36][llama_recipes.utils.config_utils][INFO] - Using batching strategy: custom
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need remove

try:
#loss = model(**batch).loss
outputs, *rest = model(**batch)
except Exception as e:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clean up

Copy link
Collaborator

@ddlBoJack ddlBoJack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. clean up duplication and your own marks.
  2. solve the wandb bug with config update.

@ddlBoJack ddlBoJack closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants