Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python identifiers for the env command #212

Merged
merged 1 commit into from Apr 23, 2018
Merged

Add Python identifiers for the env command #212

merged 1 commit into from Apr 23, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2018

Hello! 👋

At the moment, Python scripts without an extension get ignored by Tokei, so if you have scripts taking the role of executables in the same fashion as shell scripts, Tokei won't count those files properly.

So, this PR will make no-extension files with this line of code work as expected for end-users:

#!/usr/bin/env python3

This PR adds identifiers for python, python2 and python3.

@ghost
Copy link
Author

ghost commented Apr 7, 2018

I read some previous issues (#208 and #186) relating to this.

What do you think about having more version identifiers? I only included the 3 most common ones.

Do you think that more version identifiers would be necessary for completeness sake? If you don't mind the big list, I can add all of the minor versions up to 3.6 to the list before the potential merge.

@XAMPPRocky
Copy link
Owner

Thank you for this PR! Can you rebase this change onto the current master so it can pass the travis tests?

@ghost
Copy link
Author

ghost commented Apr 8, 2018

Done. Waiting for Travis.

@ghost
Copy link
Author

ghost commented Apr 20, 2018

Any idea on why the NetBSD build failed?

@XAMPPRocky
Copy link
Owner

@seiks I’ve filed an issue on trust about it it can be ignored.

@ghost
Copy link
Author

ghost commented Apr 20, 2018

In that case I feel that this PR can be merged. All the other builds succeeded.

@XAMPPRocky XAMPPRocky merged commit f585c4c into XAMPPRocky:master Apr 23, 2018
@XAMPPRocky
Copy link
Owner

Thank you for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant