Better blinding #100
Merged
Better blinding #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Dan, this looks fine. I took the liberty of adding a few comments, fixing a typo ('number' -> number), and removing an unneeded except (KeyError should happen when using get_run_info asking for a single field). If you agree feel free to merge (unless @feigaodm sees a problem?) Congratulations on the #100 by the way ;-) |
|
I have no problem with merging but I'd leave the #blinded tag in until at least a couple people try this out on a few (unblinded) runs. I'll wait for advice from Fei though. |
|
Sorry that I responded to @coderdj only, definitely it's a better way for blinding. Maybe we can test it with new runs without 'blinded' tag, but it's not a stopper to to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parameter 'blind_from_run'. Setting this to a run number automatically blinds all background_stable runs after this point unless they are specifically tagged 'unblinded' or '_unblinded'.
This should make it so shifters don't have to put the blinded tag on each run and should remove the possibility of accidentally unblinding because a shifter forgets or misspells this tag.