Update Extended treemaker for S2Single cut #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add other_s2_area because the condition for other_s2 is the largest S2 after main S1 that not in main interaction, while largest_other_s2 doesn't necessary happen after main S1. Also the reason not just use alt_s2_interaction is that we don't want to miss identify multiple scatter when largest_other_s2 happens before main S1 and make alt_s2_interaction return 'nan'
feigaodm
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add other_s2_area because the condition for other_s2 is the largest S2 after main S1 that not in main interaction, while largest_other_s2 doesn't necessary happen after main S1.
Also the reason not just use alt_s2_interaction is that we don't want to miss identify multiple scatter when largest_other_s2 happens before main S1 and make alt_s2_interaction return 'nan'