Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip strings in acquisition monitor files (see pax#607 and pax#608) #142

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

JelleAalbers
Copy link
Contributor

This makes the acquisition monitor pulse file reading code robust to the change introduced in XENON1T/pax#608 . Files from old runs will remain readable.

Copy link

@XeBoris XeBoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But just a stupid question about the consequences then: What about old runs which are already in the rucio catalog? We need to delete the zero sized *pickles file there. Are there any consequences if no *pickles file is found?
Line 141 will result an error if there is no file, won't it?

@JelleAalbers
Copy link
Contributor Author

You could replace them with a random pickle too if they're causing problems -- I can only change what happens for new runs. I think an error is useful if the file is missing; it could be missing for many reasons.

@XeBoris
Copy link

XeBoris commented Sep 15, 2017

@JelleAalbers It sounds not useful to replace zero-sized *pickle files in the rucio catalogue by some file which has some minor random content. I know only of @ershockley who downloads this file from the rucio catalogue and put them into a folder for the analysts. Does hax itself need the file?

@JelleAalbers
Copy link
Contributor Author

JelleAalbers commented Sep 15, 2017

Evan downloads them because they're needed for making the proximity minitrees. There's a difference between an absent acquisition monitor file (indicating some transfer issue) or an empty/header-only file (indicating no aq.m. signals were stored, though we tried; likely a DAQ problem). I think we had both kinds of issues in the past.

If I'd have known Rucio doesn't like empty files I wouldn't have made them, but preventing their creation in the future is all I can do for you now.

@pdeperio pdeperio merged commit 3ae0fae into master Sep 25, 2017
@pdeperio pdeperio deleted the nonzero_aqm_files branch September 25, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants