New data map names #186
Merged
New data map names #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge with next pax release? |
|
Good to go with XENON1T/pax#654 |
|
@l-althueser now that unblinding done, can we revisit? I think it's just solving the one conflict. Sorry for delay. |
|
Updated. |
|
@feigaodm @l-althueser this should also be merged with XENON1T/pax#654? |
|
Yes, otherwise HAX wouldn't find the maps anymore. |
feigaodm
approved these changes
Mar 18, 2018
|
yeah, let's merge it and test. This won't change the versioned env pax_v6.8.0 so won't affect SR1 analysis. Let's see if people see bugs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the data map names to the ones in XENON1T/pax#654
Wait for this PR in PAX first or cancel both ;)