Standard set of minitrees for Science Run available at hax.load() #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunnell
requested review from
JelleAalbers,
coderdj,
pdeperio and
darrylmasson
|
Do people want 'all' to be default? That would be a reasonable default but I don't want to break compatibility with existing code. |
|
The default 'Basics' and 'Fundamentals' used to cover a lot, but without (x,y,z) and cs1 and cs2, I don't think you can do much with them anymore, so I'd be surprised if any existing code relying on the defaults still worked anyway. |
|
@darrylmasson fixed, default to all |
darrylmasson
approved these changes
Feb 27, 2018
|
Can somebody not me merge before this goes stale? |
coderdj
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most use cases load a standard set of minitrees for use with lax for most single scatter analysis. This means that now we can do:
hax.minitrees.load(28192, minitrees='all')The list of minitrees came from:
https://github.com/XENON1T/SR1Results/blob/master/Calibration/inputs_for_bbf/reduce_data.py#L137