This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Fdc quick fix #285
Merged
Fdc quick fix #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joran Angevaare <jorana@nikhef.nl>
|
@zhut19 A question for this one: if we do this, don't we lose compatibility with (x,y,z) maps from 1T? Do you think it would make sense to have something deciding based on the average of the 3rd component? If positive it must be drift time, so scale, otherwise it is a z coordinate? |
|
@ftoschi This part is added under the 'xenonnt' detector condition, so I would say 1T is alright. |
|
Oh yes, thanks, I did not check carefully enough! |
ftoschi
approved these changes
Feb 18, 2022
|
I do not really have time now to test it, but @zhut19 is right as the FDC map should be scaled. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
FDC map coordinate system is in drift time and should be rescaled for interpolating x-y-z input.