Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using jax.random.binomial #148

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Try using jax.random.binomial #148

merged 8 commits into from
Mar 7, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Mar 6, 2024

Following jax-ml/jax#18228

But the jax.random.binomial can only be used in the jax version equal to or higher than 0.4.21. So the CUDA 11 should still use numpyro's _binomial_dispatch.

@dachengx dachengx requested a review from zihaoxu98 March 6, 2024 08:53
@dachengx dachengx marked this pull request as ready for review March 6, 2024 08:53
@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 8179543516

Details

  • 27 of 42 (64.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 85.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
appletree/randgen.py 27 42 64.29%
Totals Coverage Status
Change from base Build 8168985205: 0.07%
Covered Lines: 2275
Relevant Lines: 2672

💛 - Coveralls

Copy link
Collaborator

@zihaoxu98 zihaoxu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks amazing

@zihaoxu98 zihaoxu98 merged commit 713ff3d into master Mar 7, 2024
7 checks passed
@zihaoxu98 zihaoxu98 deleted the jax_binomial branch March 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants