This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Fix cut_by_eventid again #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramirezdiego
approved these changes
Jan 25, 2024
PavelKavrigin
added a commit
that referenced
this pull request
Feb 4, 2024
* Fix cut_by_eventid again * Fix cut_by_eventid again (#80) Co-authored-by: Pavel Kavrigin <pkavrigin@midway3-login4.rcc.local> --------- Co-authored-by: Pavel Kavrigin <pkavrigin@midway3-login4.rcc.local>
ramirezdiego
added a commit
that referenced
this pull request
Feb 7, 2024
* added option to apply total Edep selection, in order to save resources before WFSim * update the function for tot_e calculation * move functions to common.py. Add explanations of new options in README * bug fix * Add escape for empty instructions after the energy selection * add some lines so that to return empty instructions in case no events left after the energy selection * Merge master with cut_by_eventid fix (#81) * Fix cut_by_eventid again * Fix cut_by_eventid again (#80) Co-authored-by: Pavel Kavrigin <pkavrigin@midway3-login4.rcc.local> --------- Co-authored-by: Pavel Kavrigin <pkavrigin@midway3-login4.rcc.local> * Polish description in README --------- Co-authored-by: Masatoshi Kobayashi <kobayashi1@midway3-login4.rcc.local> Co-authored-by: Masatoshi Kobayashi <mk4212@columbia.edu> Co-authored-by: Pavel Kavrigin <68543201+PavelKavrigin@users.noreply.github.com> Co-authored-by: Pavel Kavrigin <pkavrigin@midway3-login4.rcc.local> Co-authored-by: Diego Ramírez García <diego.ramirez@physik.uni-freiburg.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix introduced in PR#75 created some issues for mc_chain because we pass the actual G4 eventid to wfsim in order to add some offset to event times according to the specified rate. However, in epix this cut refers to indices of G4 events, not to G4 eventids. Since
cut_by_eventidwas set to True in epix configuration, all simulations, except for the one where G4 eventid started at 0, had zero events in the epix output after PR#75 had been propagated tomontecarlo-development.I did more thorough tests and updated
cut_by_eventidtreatment again, here's the test notebook:/project2/lgrandi/pkavrigin/2024-01-21_test_epix/2024-01-21_TestEPIX.ipynb
In the notebook "expected" means the number of events from G4 file which we expect to see in the epix output with the given parameters, and "result" is what we actually get.
Output with the current epix master branch:
Output with
fix_evtid_againbranch: