-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no rechunking for microphysics summary #140
Conversation
Pull Request Test Coverage Report for Build 8017799725Details
💛 - Coveralls |
Looks like our field map returned a few |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it extensively and the change did solve the problems I had with the NaN values in the field. Works well now.
Thanks @HenningSE !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey both, could we narrow down where in the detector these NaN pop up? Just to be sure the map handling is good and we are here addressing cases where the field is beyond our sensitive volume (also to decide if setting it to zero is the right fix).
All good. @HenningSE checked the position of NaNs in our field maps and these make valid the clipping to zero. |
No description provided.