Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no rechunking for microphysics summary #140

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

HenningSE
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8017799725

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 68.615%

Totals Coverage Status
Change from base Build 8003613039: 0.01%
Covered Lines: 1655
Relevant Lines: 2412

💛 - Coveralls

@HenningSE
Copy link
Collaborator Author

Looks like our field map returned a few nan values that stoped nestpy from returning quanta. The last commit will set nan fields to 0 and print a warning message similar to the negative field values.

@HenningSE HenningSE marked this pull request as ready for review February 23, 2024 12:01
Copy link
Member

@cfuselli cfuselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it extensively and the change did solve the problems I had with the NaN values in the field. Works well now.
Thanks @HenningSE !

Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey both, could we narrow down where in the detector these NaN pop up? Just to be sure the map handling is good and we are here addressing cases where the field is beyond our sensitive volume (also to decide if setting it to zero is the right fix).

@ramirezdiego
Copy link
Collaborator

Hey both, could we narrow down where in the detector these NaN pop up? Just to be sure the map handling is good and we are here addressing cases where the field is beyond our sensitive volume (also to decide if setting it to zero is the right fix).

All good. @HenningSE checked the position of NaNs in our field maps and these make valid the clipping to zero.

@ramirezdiego ramirezdiego merged commit 002b91f into main Feb 26, 2024
3 checks passed
@ramirezdiego ramirezdiego deleted the fix_rechunking_microphysicssummary branch February 26, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants