-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bokeh v3 and holoviews v1, drop py3.8 support #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dachengx
changed the title
Update to bokeh v3 and holoviews v1
Update to bokeh v3 and holoviews v1, drop py3.8 support
Jan 15, 2024
WenzDaniel
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will drop 3.8 python support. We will also drop nestpy from ax_env to prevent failing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
Close #1206
Depends on XENONnT/ax_env#362 and XENONnT/ax_env#363
Drop python 3.8 because bokeh>=3.2.0 stops support py3.8.
The test for Python 3.11 is experimental, not expect can pass. nestpy==2.0.0 does not support py3.11 now.
Also, minor update of SCADA interface:
if np.all((run_id, self.context)):
toif run_id is not None and self.context is not None:
for numpy compatibility.Can you briefly describe how it works?
plot_width
towidth
andplot_height
toheight
forbokeh.plotting.figure
style
tostyles
forbokeh.models.Div
names=list
toname=str
forbokeh.models.HoverTool
sizing_mode
to"scale_width"
for better visualization in the jupyter notebookhv.opts.apply_groups
to set grouped options, to be compatible with https://github.com/holoviz/holoviews/blob/62b7f1ea47461173253a123765a7d555a0c239ea/holoviews/core/accessors.py#L573Can you give a minimal working example (or illustrate with a figure)?