Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bokeh v3 and holoviews v1, drop py3.8 support #1318

Merged
merged 13 commits into from
Jan 15, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jan 15, 2024

What does the code in this PR do / what does it improve?

Close #1206

Depends on XENONnT/ax_env#362 and XENONnT/ax_env#363

Drop python 3.8 because bokeh>=3.2.0 stops support py3.8.

The test for Python 3.11 is experimental, not expect can pass. nestpy==2.0.0 does not support py3.11 now.

Also, minor update of SCADA interface: if np.all((run_id, self.context)): to if run_id is not None and self.context is not None: for numpy compatibility.

Can you briefly describe how it works?

  1. change plot_width to width and plot_height to height for bokeh.plotting.figure
  2. change style to styles for bokeh.models.Div
  3. change names=list to name=str for bokeh.models.HoverTool
  4. set all sizing_mode to "scale_width" for better visualization in the jupyter notebook
  5. use hv.opts.apply_groups to set grouped options, to be compatible with https://github.com/holoviz/holoviews/blob/62b7f1ea47461173253a123765a7d555a0c239ea/holoviews/core/accessors.py#L573

Can you give a minimal working example (or illustrate with a figure)?

@dachengx dachengx marked this pull request as ready for review January 15, 2024 05:48
@dachengx dachengx changed the title Update to bokeh v3 Update to bokeh v3 and holoviews v1 Jan 15, 2024
@dachengx dachengx mentioned this pull request Jan 15, 2024
@coveralls
Copy link

Coverage Status

coverage: 91.488% (-0.9%) from 92.424%
when pulling 749f293 on update_bokeh
into 3afa397 on master.

@dachengx dachengx changed the title Update to bokeh v3 and holoviews v1 Update to bokeh v3 and holoviews v1, drop py3.8 support Jan 15, 2024
Copy link
Collaborator

@WenzDaniel WenzDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will drop 3.8 python support. We will also drop nestpy from ax_env to prevent failing tests.

@WenzDaniel WenzDaniel merged commit 3368128 into master Jan 15, 2024
8 of 9 checks passed
@dachengx dachengx deleted the update_bokeh branch January 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bokeh version to 3
3 participants