Auto detection of local ip #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julius2342
reviewed
Feb 28, 2019
Julius2342
reviewed
Feb 28, 2019
farmio
commented
Feb 28, 2019
| self.xknx.logger.debug( | ||
| "No interface on same subnet as gateway found. Falling back to default gateway.") | ||
| default_gateway = _find_default_gateway() | ||
| local_ip = _scan_interfaces(default_gateway) |
There was a problem hiding this comment.
Shall we try: except: and raise here?
xknx/core/config.py
Outdated
| self._parse_connection_prefs(ConnectionType.AUTOMATIC, prefs) | ||
| elif conn.startswith("tunneling"): | ||
| elif conn == "tunneling": | ||
| self._parse_connection_prefs(ConnectionType.TUNNELING, prefs) |
There was a problem hiding this comment.
Shall we raise if tunneling: is used without gateway_ip:? Or maybe just logger.warning and fall back to ConnectionType.AUTOMATIC ?
There was a problem hiding this comment.
I think we should raise ...
farmio
commented
Mar 6, 2019
| scan_filter.tunnelling = True | ||
| elif connection_type == ConnectionType.ROUTING: | ||
| scan_filter.routing = True | ||
| self.scan_filter = scan_filter |
There was a problem hiding this comment.
GatewayScanFilter now accounting ConnectionType on initialization. I was thinking it wouldn't make sense to scan for routers if a tunneling connection shall be made (and vice versa).
Julius2342
approved these changes
Apr 7, 2019
Julius2342
approved these changes
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
local_ipoptional for tunneling and routing ConnectionConfig.Tunnelling
Routing
local_ipis configured KNXIPInterface is started like Automatic with a GatewayScanFilter searching only routing devices. If the filter is set only routing connections will be made.