Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover: fix position update #537

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Conversation

farmio
Copy link
Member

@farmio farmio commented Dec 19, 2020

Description

when a cover can't move (eg. locked) and set_down() is called the travelcalculator starts. because of _position_current.value has not changed in this case its callback is not called when a GroupValueResponse comes in - eg. sync() is used.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

when a cover can't move (eg. locked) and `set_down()` is called the travelcalculator starts. because of _position_current.value has not changed in this case its callback is not called when a GroupValueResponse comes in - eg. `sync()` is used.
@coveralls
Copy link

coveralls commented Dec 19, 2020

Coverage Status

Coverage decreased (-0.1%) to 94.65% when pulling 1688395 on farmio:fix-cover-position-update into 30720c7 on XKNX:master.

@farmio farmio merged commit 03c9673 into XKNX:master Dec 21, 2020
@farmio farmio deleted the fix-cover-position-update branch December 21, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants